Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend name search to use all lists #449

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deadmangareader
Copy link

This PR accomplishes enhancement tracked in #441 .

Comment on lines +367 to +378
DeniedPersons: searcher.TopDPs(limit, minMatch, name),
BISEntities: searcher.TopBISEntities(limit, minMatch, name),
MilitaryEndUsers: searcher.TopMEUs(limit, minMatch, name),
SectoralSanctions: searcher.TopSSIs(limit, minMatch, name),
Unverified: searcher.TopUVLs(limit, minMatch, name),
NonproliferationSanctions: searcher.TopISNs(limit, minMatch, name),
ForeignSanctionsEvaders: searcher.TopFSEs(limit, minMatch, name),
PalestinianLegislativeCouncil: searcher.TopPLCs(limit, minMatch, name),
CaptaList: searcher.TopCAPs(limit, minMatch, name),
ITARDebarred: searcher.TopDTCs(limit, minMatch, name),
NonSDNChineseMilitaryIndustrialComplex: searcher.TopCMICs(limit, minMatch, name),
NonSDNMenuBasedSanctionsList: searcher.TopNS_MBS(limit, minMatch, name),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will perform each search in serial, so requests will take quite a long time to complete. Can we use the gatherings functions to speed this up?

@adamdecaf adamdecaf added this to the v0.24.0 milestone Oct 25, 2022
@adamdecaf adamdecaf modified the milestones: v0.24.0, v0.25.0 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants