Clarify precautions around hooks which dispatch on install/upgrade #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Mar 24, 2025
cameron1729
force-pushed
the
hooks-during-install
branch
2 times, most recently
from
80fdff9 to
fa165fc
Compare
cameron1729
force-pushed
the
hooks-during-install
branch
from
fa165fc to
7c34d75
Compare
|
Thanks @andrewnicols - I've updated the wording, removed line breaks, and added backticks. |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the documentation to clarify precautions required when handling hooks that may be dispatched during system installation or upgrade. Key changes include:
- Updating the caution block to reference hooks instead of legacy callbacks.
- Detailing additional checks required when the database or API calls are made during installation or upgrade.
- Informing users about potential changes needed when porting legacy callbacks to hooks.
andrewnicols
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.