Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare PHP 8.4 supported #1293

Merged
merged 1 commit into from
Apr 3, 2025
Merged

Declare PHP 8.4 supported #1293

merged 1 commit into from
Apr 3, 2025

Conversation

andrewnicols
Copy link
Member

  • Do it in the PHP policy page: By MDL-80117, since 5.0
  • Update 5.0 release notes (not needed in this case, it's already showing the correct PHP 8.4 information).

@andrewnicols
Declare PHP 8.4 supported
af517a8 
- Do it in the PHP policy page: By MDL-80117, since 5.0
- Update 5.0 release notes (not needed in this case, it's
    already showing the correct PHP 8.4 information).
@andrewnicols andrewnicols added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Mar 13, 2025
@andrewnicols andrewnicols requested a review from Copilot March 13, 2025 04:45
Copilot
Copilot AI reviewed Mar 13, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@netlify Netlify
Copy link

netlify bot commented Mar 13, 2025 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit af517a8
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/67d262ed90f06b0008c278f9
😎 Deploy Preview https://deploy-preview-1293--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewnicols andrewnicols marked this pull request as ready for review April 3, 2025 03:55
@andrewnicols andrewnicols requested a review from Copilot April 3, 2025 03:55
Copilot
Copilot AI reviewed Apr 3, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR declares PHP 8.4 support for Moodle 5.0 and later releases in accordance with MDL-80117.

  • Added a new section for PHP 8.4 in the PHP policy page
  • References the required version and issue number for consistency with the PHP support documentation

junpataleta
junpataleta approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@junpataleta junpataleta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@junpataleta junpataleta added this pull request to the merge queue Apr 3, 2025
Merged via the queue into moodle:main with commit f6660b9 Apr 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@junpataleta junpataleta junpataleta approved these changes

Assignees

@andrewnicols andrewnicols

Labels
blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnicols @junpataleta