Using kubernetes-mixin as a base, add a README. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
|
The design as a pdf seems kind of odd, why not markdown? |
|
I just cross read, but this lgtm in my experience this will improve over time anyways as the community contributes things that are unclear where we are likely too close to the concept to realize. |
metalmatze
reviewed
Nov 15, 2018
|
|
||
| ``` | ||
| $ go get github.com/jsonnet-bundler/jsonnet-bundler/cmd/jb | ||
| $ brew install jsonnet |
There was a problem hiding this comment.
IMHO we should not only show how to brew install here
metalmatze
reviewed
Nov 15, 2018
|
|
||
| ``` | ||
| $ go get github.com/jsonnet-bundler/jsonnet-bundler/cmd/jb | ||
| $ brew install jsonnet |
There was a problem hiding this comment.
Just found that nobody really has official support yet. Maybe linking to AUR is ok, but also not as important then.
Suggested change
| $ brew install jsonnet | |
| # macOS | |
| $ brew install jsonnet | |
| # Archlinux AUR | |
| $ yay -S jsonnet |
metalmatze
approved these changes
Nov 15, 2018
Signed-off-by: Tom Wilkie <[email protected]>
|
PDF because its a google doc, and there is no export as markdown. Plus that design is kinda immutable now - future changes should be new designs IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @metalmatze @brancz