Bump mongoid version to 6 #102

sivagollapalli · 2016-09-12T06:22:00Z

No description provided.

sivagollapalli · 2016-09-26T13:20:22Z

@mauriciozaffari Looks like bundler 1.13.1 has an issue to find out .gemspec file. Build is running with bundler 1.11 on my local system. Could you please help?

mysticaltech · 2016-12-20T00:51:24Z

This branch works on my rails 5 install, with the latest stable mongoid gem. Thank you for your good work ! However I am getting this issue #107 .. The relevancy value is always 1.0 .. If you have any idea what could be causing this, I would really appreciate. Thanks

dblock · 2016-12-20T05:00:40Z

Can someone finish this PR with a passing build, please? I'm happy to check it out, merge, etc.

rmcsharry · 2017-02-14T10:46:39Z

Is this project dead? If you click the details on the build TravisCI cannot find the repo...?

mysticaltech · 2017-02-14T14:11:38Z

I wouldn't rely on it.. I've personally moved over to searchkick

dblock · 2017-02-14T14:31:28Z

Or https://github.com/mongoid/mongoid_fulltext

rtrv · 2017-10-30T12:19:06Z

@sivagollapalli could you rebase your PR to current master with working CI for Mongoid 3-5 and check tests passing for Mongoid 6? If all of them are passed, we could say there is support for Mongoid 6 and close #115

sivagollapalli · 2017-10-30T12:45:32Z

@rtrv Sure I will rebase and update PR.

…id_rc_support

rtrv · 2017-10-30T16:56:34Z

spec/mongoid_search_spec.rb

      :category => Category.new(:name => "Mobile", :description => "Reviews"),
      :subproducts => [Subproduct.new(:brand => "Apple", :name => "Craddle")],
      :info => { :summary => "Info-summary",
                 :description => "Info-description"}
+      @tags = ["Amazing", "Awesome", "Olé"].map { |tag| Tag.create(:name => tag, product: @product) }


I suppose, you've changed tags creation because of ActiveSupport's call error, but if you use release Mongoid 6.0, this error doesn't appear. Revert tags initiation, it should work well

@rtrv But, I am getting the same error if I run specs against MongoDB 2.6.12 and mongoid 6.0.3. Here is the spec output

1) Mongoid::Search Serialized hash fields when the hash is populated should return the product Failure/Error: @product = Product.create :brand => "Apple", NoMethodError: undefined method `call' for #<ActiveSupport::Callbacks::CallbackSequence:0x007fd6906e8e08> # ./spec/mongoid_search_spec.rb:20:in `block (2 levels) in <top (required)>'

@sivagollapalli it's strange, I've just fixed it by changing Mongoid 6 version from beta to release one. Try 6.0.0 instead of 6.0.3

@rtrv Just checked with mongoid 6.0.0. Still, it shows same error.

@sivagollapalli hm, interesting. I'm checking it on my machine at this week, wanna fix 6.0 support and some minor bugs to push the gem to 0.4 by the middle of December

rtrv · 2017-10-30T16:58:08Z

Gemfile

+  gem 'mongoid', '~> 3.1'                                                                                     
+else                                                                                                          
+  gem 'mongoid', version                                                                                      
+end


Use Gemfile from master and just uncomment lines 10-11, and change line 20 to '~> 6.0'

rtrv · 2017-10-30T17:02:06Z

spec/mongoid_search_spec.rb

@@ -280,7 +289,8 @@
  context "relevant search" do
    before do
      Mongoid::Search.relevant_search = true
-      @imac = Product.create :name => 'apple imac'
+      category = Category.create(name: 'New Category')
+      @imac = Product.create :name => 'apple imac', category: category 


Why have you added category here? If there is an error if an object without category is created, we should change validations for Product class

rtrv · 2017-10-30T17:02:34Z

spec/mongoid_search_spec.rb

      :category => Category.new(:name => "Vehicle")
+    ["Amazing", "First", "Car"].map { |tag| Tag.create(:name => tag, product: @product) }


The same about tags

rtrv · 2017-10-30T17:02:52Z

spec/mongoid_search_spec.rb

-    expect(Variant.full_text_search("oeuvre")).to eq [variant1]
-    expect(Variant.full_text_search("æquo")).to eq [variant2]
-    expect(Variant.full_text_search("aequo")).to eq [variant2]
+    ["œuvre"].map { |tag| Tag.create(:name => tag, variant: variant1) } 


The same about tags

rtrv · 2017-10-30T17:02:57Z

spec/mongoid_search_spec.rb

+    ["œuvre"].map { |tag| Tag.create(:name => tag, variant: variant1) } 
+
+    variant2 = Variant.create category: Category.create(name: 'New Category')
+    ["æquo"].map { |tag| Tag.create(:name => tag, variant: variant2) }


The same about tags

rtrv · 2017-10-30T17:03:03Z

spec/mongoid_search_spec.rb

      :category => Category.new(:name => "Mobile"),
      :subproducts => [Subproduct.new(:brand => "Apple", :name => "Craddle")],
      :color => :white
+
+    ["Amazing", "Awesome", "Olé"].map { |tag| Tag.create(:name => tag, variant: variant) }


The same about tags

rtrv · 2017-10-30T17:03:17Z

spec/mongoid_search_spec.rb

        :category => Category.new(:name => "процессоры"),
        :subproducts => []
+
+     ["Amazing", "Awesome", "Olé"].map { |tag| Tag.create(:name => tag, product: @product) }


The same about tags

dblock · 2017-12-22T19:57:41Z

Replaced with #124.

Siva Gollapalli added 2 commits September 12, 2016 11:49

Bump mongoid version from beta to RC

0950062

Added mongoid 6 support

28cec3a

sivagollapalli changed the title ~~Bump mongoid version from beta to RC~~ Bump mongoid version to 6 Sep 26, 2016

dblock mentioned this pull request Oct 10, 2017

More maintainers for this repo #111

Open

Merge branch 'master' of github.com:mongoid/mongoid_search into mongo…

68b22a4

…id_rc_support

rtrv requested changes Oct 30, 2017

View reviewed changes

dblock mentioned this pull request Dec 22, 2017

Compatibility with Mongoid 6. #124

Merged

dblock closed this Dec 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump mongoid version to 6 #102

Bump mongoid version to 6 #102

sivagollapalli commented Sep 12, 2016

sivagollapalli commented Sep 26, 2016

mysticaltech commented Dec 20, 2016

dblock commented Dec 20, 2016

rmcsharry commented Feb 14, 2017

mysticaltech commented Feb 14, 2017

dblock commented Feb 14, 2017

rtrv commented Oct 30, 2017

sivagollapalli commented Oct 30, 2017

rtrv Oct 30, 2017

sivagollapalli Nov 7, 2017

rtrv Nov 8, 2017

sivagollapalli Dec 4, 2017

rtrv Dec 4, 2017

rtrv Oct 30, 2017

rtrv Oct 30, 2017

rtrv Oct 30, 2017

rtrv Oct 30, 2017

rtrv Oct 30, 2017

rtrv Oct 30, 2017

rtrv Oct 30, 2017

dblock commented Dec 22, 2017

		:category => Category.new(:name => "Vehicle")
		["Amazing", "First", "Car"].map { \|tag\| Tag.create(:name => tag, product: @product) }

Bump mongoid version to 6 #102

Bump mongoid version to 6 #102

Conversation

sivagollapalli commented Sep 12, 2016

sivagollapalli commented Sep 26, 2016

mysticaltech commented Dec 20, 2016

dblock commented Dec 20, 2016

rmcsharry commented Feb 14, 2017

mysticaltech commented Feb 14, 2017

dblock commented Feb 14, 2017

rtrv commented Oct 30, 2017

sivagollapalli commented Oct 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dblock commented Dec 22, 2017