-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOP-3785: adding a persistent search bar #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!! thanks for putting this together @bianca-laube
a couple comments on persisting the search bar on empty results. will need to consult with Product team to verify base case scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor differences in behavior from whats on prod vs this branch (with flag set to "false") PTAL !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor styling nitpicks to keep prod untouched. also not seeing loading states with the new component state variables. PTAL! 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this overall LGTM. one minor functional catch below (onSubmit function for SearchInput)
thanks again for putting this together @bianca-laube !
Co-authored-by: Seung Park <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I believe there are a couple unused conditionals! Check me on it though, because there are so many layers to unpack.
Also, I feel like I may have found a bug with our search, but it's not a part of this ticket. Any one letter search seems to hang in loading state oddly. Something to keep an eye on. Bonus points!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! minor styling issue below and a possible refactor (not blocking). besides that LGTM !
Stories/Links:
DOP-3785
Current Behavior:
https://www.mongodb.com/docs/search/?q=test
Staging Links:
https://docs-mongodb-org-stg.s3.us-east-2.amazonaws.com/master/landing/bianca.laube/DOP-3785/search/index.html?q=test
Notes:
Things Changed: