Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4996: Table initiates in dark/light mode #1241

Merged
merged 33 commits into from
Sep 18, 2024
Merged

DOP-4996: Table initiates in dark/light mode #1241

merged 33 commits into from
Sep 18, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Sep 18, 2024 •
edited
Loading

Stories/Links:

DOP-4996

Current Behavior:

global-clusters
driver-connection (striped)
docs
more docs

Staging Links:

global-clusters
driver-connection (striped)
docs
more docs

Notes:

Initiates in Dark Mode if user pref is dark mode without flash of light mode.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

seungpark and others added 30 commits August 2, 2024 11:18
@seungpark
set tests and lh upload to work on feature branch
5e3f633
@seungpark
Merge branch 'main' into DOP-4616
9425ea9
@seungpark
DOP-4879: use feedback widget in action bar (desktop) (#1193)
da758be
@seungpark
Merge branch 'main' into DOP-4616
59d7033
@seungpark
Merge branch 'main' into DOP-4616
1030ffb
@seungpark
Merge branch 'main' into DOP-4616
a0a2af6
@seungpark
Update global-dark-mode.css
93ef033
@seungpark
DOP-4770: add search input using docs search and chatbot (#1197)
f8c0da8
@seungpark
DOP-4908 - Mobile and Tablet versions of universal search bar (#1204)
e54723f
@seungpark
Merge branch 'main' into DOP-4616
0441fad
@seungpark
DOP-4897: Update sidenav on scroll (#1207)
ac541a4
@seungpark
DOP-4909: feedback form works on mobile with new action bar (#1209)
591eb1c
@seungpark
Merge branch 'main' into DOP-4616
15a31ac
@seungpark
DOP-4928 - update docs search page for action bar (#1211)
f36f875
@seungpark
Merge branch 'main' into DOP-4616
6b74c1f
@seungpark
DOP-4968 update darkmode icons (#1223)
8f0ee88
@biancalaube @seungpark @bianca-laube
DOP-4960: Updated refresh on search page dark mode (#1221)
44bf1a0 
Co-authored-by: Seung Park <[email protected]>
Co-authored-by: biancalaube <[email protected]>
@seungpark
Merge branch 'main' into DOP-4616
632c79e
@seungpark
DOP-4990: remove feedback from actionbar for specific projects (#1229)
1001a97
@seungpark
Merge branch 'main' into DOP-4616
2f5fc84
@seungpark
Merge branch 'main' into DOP-4616
e805787
@seungpark
DOP-4999: add width/height to svg and make button a block (#1233)
d395866
@mmeigs
DOP-4994: Feedback Button horizontal text in all languages (#1238)
09a524f
@mmeigs
Easiest solution: disallow option and hotkey in locale not en-us (#1240)
c8eaf7c
@seungpark
Merge branch 'main' into DOP-4616
ff46c6d
@mmeigs
ListTable dark mode flash - contained for text colors and header back…
b21974b 
…grounds
@mmeigs
reuse shouldAlternateRowColor
7fab2db
@mmeigs
zebraStripingStyle
d66096c
@mmeigs
zebra striping applied
0d06698
@mmeigs
Merge branch 'main' into DOP-4996-table-flash
d20c547
mayaraman19
mayaraman19 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mayaraman19 mayaraman19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a mini nit but this looks good to me! We might want to also drop in a ff ticket to initialize literals in dark mode since their flash is noticeable

src/components/ListTable.js Outdated Show resolved Hide resolved
@mmeigs mmeigs merged commit 0c16c08 into main Sep 18, 2024
4 checks passed
@mmeigs mmeigs deleted the DOP-4996-table-flash branch September 18, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayaraman19 mayaraman19 mayaraman19 approved these changes

@seungpark seungpark Awaiting requested review from seungpark

@anabellabuckvar anabellabuckvar Awaiting requested review from anabellabuckvar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmeigs @mayaraman19 @seungpark @biancalaube