Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4990: remove fab from depreacted projects #1227

Merged
merged 2 commits into from
Sep 10, 2024
Merged

DOP-4990: remove fab from depreacted projects #1227

merged 2 commits into from
Sep 10, 2024

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Sep 10, 2024 •
edited
Loading

Stories/Links:

DOP-4990
Removing feedback FAB from docs outlined in ticket

Current Behavior:

atlas data lake
atlas app services

Staging Links:

atlas data lake
realm
atlas app services
regression check for cloud docs

Notes:

  • Incoming separate PR for removing feedback button from action bar, targeting feature branch

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@seungpark seungpark marked this pull request as ready for review September 10, 2024 15:58
rayangler
rayangler approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. We should definitely consider having a future ticket to give writers more control over this

@seungpark
Copy link
Collaborator Author

Thanks for the quick fix. We should definitely consider having a future ticket to give writers more control over this

Good point! dropped in a ticket for that https://jira.mongodb.org/browse/DOP-5005

@seungpark seungpark merged commit e9010a9 into main Sep 10, 2024
4 checks passed
@seungpark seungpark deleted the DOP-4990 branch September 10, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayangler rayangler rayangler approved these changes

@mmeigs mmeigs Awaiting requested review from mmeigs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seungpark @rayangler