Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-4995: Dark Mode UAT: always on scroll, version selector hover flash, clear all filters flash #1226

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Sep 10, 2024

Stories/Links:

DOP-4995, DOP-4997, DOP-4998

Current Behavior:

Cloud-docs (user always on scrollbar)
Landing search (search filter button flash)
Manual (version selector hover)

Staging Links:

Cloud-docs (user always on scrollbar)
Landing search (search filter button flash)
Manual (version selector hover)

Notes:

These three tickets are from UAT bug reporting spreadsheet.

  1. If a user has Always-On scrolling (user setting computer-wide), that particular scrollbar was not in dark mode. This fixes that. Photos below.
  2. Clear all filters button in search had a light mode flash on load.
  3. Version Selector in sidenav had flash of light mode on load only when on hover.

Scroll photos

Before:
Screenshot 2024-09-09 at 2 17 14 PM

After:
Screenshot 2024-09-09 at 4 11 41 PM

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM. i'll have to merge this into feature branch as well!

src/styles/global-dark-mode.css Show resolved Hide resolved
src/components/SearchResults/SearchFilters.js Outdated Show resolved Hide resolved
@mmeigs mmeigs merged commit b6b72aa into main Sep 11, 2024
4 checks passed
@mmeigs mmeigs deleted the DOP-4995-scroll-dark branch September 11, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants