Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4616: Search on every page #1189

Merged
merged 27 commits into from
Sep 18, 2024
Merged

DOP-4616: Search on every page #1189

merged 27 commits into from
Sep 18, 2024

Conversation

seungpark
Copy link
Collaborator

@seungpark seungpark commented Aug 2, 2024 •
edited
Loading

DOP-4616

Feature branch for dark mode + universal search.
This branch should only have merge commits from PR's that scope out smaller tasks.

These have been staged with the env flag GATSBY_ENABLE_DARK_MODE=true:

cloud docs
landing
404
app services
server

Refer to this spreadsheet for bug tracking

@seungpark seungpark changed the title set tests and lh upload to work on feature branch DOP-4616: set tests and lh upload to work on feature branch Aug 2, 2024
@seungpark seungpark changed the title DOP-4616: set tests and lh upload to work on feature branch DOP-4616: Search on every page Aug 2, 2024
seungpark and others added 24 commits August 5, 2024 13:59
@seungpark
Merge branch 'main' into DOP-4616
9425ea9
@seungpark
DOP-4879: use feedback widget in action bar (desktop) (#1193)
da758be
@seungpark
Merge branch 'main' into DOP-4616
59d7033
@seungpark
Merge branch 'main' into DOP-4616
1030ffb
@seungpark
Merge branch 'main' into DOP-4616
a0a2af6
@seungpark
Update global-dark-mode.css
93ef033
@seungpark
DOP-4770: add search input using docs search and chatbot (#1197)
f8c0da8
@seungpark
DOP-4908 - Mobile and Tablet versions of universal search bar (#1204)
e54723f
@seungpark
Merge branch 'main' into DOP-4616
0441fad
@seungpark
DOP-4897: Update sidenav on scroll (#1207)
ac541a4
@seungpark
DOP-4909: feedback form works on mobile with new action bar (#1209)
591eb1c
@seungpark
Merge branch 'main' into DOP-4616
15a31ac
@seungpark
DOP-4928 - update docs search page for action bar (#1211)
f36f875
@seungpark
Merge branch 'main' into DOP-4616
6b74c1f
@seungpark
DOP-4968 update darkmode icons (#1223)
8f0ee88
@biancalaube @seungpark @bianca-laube
DOP-4960: Updated refresh on search page dark mode (#1221)
44bf1a0 
Co-authored-by: Seung Park <[email protected]>
Co-authored-by: biancalaube <[email protected]>
@seungpark
Merge branch 'main' into DOP-4616
632c79e
@seungpark
DOP-4990: remove feedback from actionbar for specific projects (#1229)
1001a97
@seungpark
Merge branch 'main' into DOP-4616
2f5fc84
@seungpark
Merge branch 'main' into DOP-4616
e805787
@seungpark
DOP-4999: add width/height to svg and make button a block (#1233)
d395866
@mmeigs
DOP-4994: Feedback Button horizontal text in all languages (#1238)
09a524f
@mmeigs
Easiest solution: disallow option and hotkey in locale not en-us (#1240)
c8eaf7c
@seungpark
Merge branch 'main' into DOP-4616
ff46c6d
anabellabuckvar
anabellabuckvar approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@anabellabuckvar anabellabuckvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! So exciting!

@seungpark seungpark merged commit ca00191 into main Sep 18, 2024
4 checks passed
@seungpark seungpark deleted the DOP-4616 branch September 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anabellabuckvar anabellabuckvar anabellabuckvar approved these changes

@mmeigs mmeigs mmeigs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seungpark @mmeigs @anabellabuckvar @biancalaube