Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NODE-6722): migrate parallel benchmarks #4404

Merged
merged 1 commit into from
Feb 10, 2025
Merged

chore(NODE-6722): migrate parallel benchmarks #4404

merged 1 commit into from
Feb 10, 2025

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Feb 6, 2025

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Last of the benchmarks to migrate

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner February 6, 2025 23:26
@nbbeeken nbbeeken force-pushed the NODE-6705-parallel-benchies branch from a71e410 to e3904a4 Compare February 7, 2025 15:23
@nbbeeken nbbeeken changed the title chore(NODE-6705): migrate parallel benchmarks chore(NODE-6722): migrate parallel benchmarks Feb 7, 2025
@W-A-James W-A-James requested review from W-A-James and removed request for a team February 7, 2025 18:25
@W-A-James W-A-James self-assigned this Feb 7, 2025
@nbbeeken nbbeeken force-pushed the NODE-6724-suite-report branch from 9fc6aca to da1c05c Compare February 7, 2025 19:10
@nbbeeken nbbeeken force-pushed the NODE-6705-parallel-benchies branch from e3904a4 to 6a61748 Compare February 7, 2025 19:11
Base automatically changed from NODE-6724-suite-report to main February 7, 2025 21:09
@nbbeeken nbbeeken force-pushed the NODE-6705-parallel-benchies branch from 6a61748 to 8936770 Compare February 7, 2025 21:11
@W-A-James
Copy link
Contributor

Verified results locally, this does not affect any driver source or CI test code, so merging over red CI.

@W-A-James W-A-James merged commit 7d744be into main Feb 10, 2025
13 of 30 checks passed
@W-A-James W-A-James deleted the NODE-6705-parallel-benchies branch February 10, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W-A-James W-A-James W-A-James approved these changes

Assignees

@W-A-James W-A-James

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @W-A-James