-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-6289): allow valid srv hostnames with less than 3 parts #4197
Conversation
bda0451
to
586f7c0
Compare
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
@aditi-khare-mongoDB @W-A-James Can we confirm the failing tests are all accounted for? |
@dariakp Seems like the two red failing tests are flaky. I doubt the purple failures would contain any failures if they weren't system failures. For example, 5.0-node-latest-server fails but not 4.0-node-latest or 6.0-node-latest, which makes me assume 5.0-node-latest would pass if not for the CI issues. |
test/integration/initial-dns-seedlist-discovery/initial_dns_seedlist_discovery.prose.test.ts
Outdated
Show resolved
Hide resolved
cdc2501
to
79f41e4
Compare
d17f346
to
eafaf61
Compare
Failing tests are unrelated known flaky tests |
LGTM with respect to my comments |
Description
Downstream changes for DRIVERS-2922 (PR).
What is changing?
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Do not throw an error on valid URI formats pre-DNS resolution, and require stricter domain matching post-DNS resolution.
Release Highlight
Allow SRV hostnames with less than three
.
separated partsIn an effort to make internal networking solutions easier to use like deployments using kubernetes, the client now accepts SRV hostname strings with one or two
.
separated parts.For security reasons, the returned addresses of SRV strings with less than three parts must end with the entire SRV hostname and contain at least one additional domain level. This is because this added validation ensures that the returned address(es) are from a known host. In future releases, we plan on extending this validation to SRV strings with three or more parts, as well.
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript