CSHARP-5471: Incorrectly resolving the authentication mechanism param… #1605
Conversation
papafe
requested review from
JamesKovacs and
sanych-sun
and removed request for
a team and
JamesKovacs
|
Hey @sanych-sun, I've tagged you since it seems you've worked on this recently.
|
|
Hey @sanych-sun, did you have additional notes about this? |
| @@ -761,7 +761,7 @@ private void ExtractOptions(Match match) | |||
| var parts = option.Value.Split('='); | |||
| var name = parts[0].Trim(); | |||
| var value = parts[1].Trim(); | |||
| _allOptions.Add(name, Uri.UnescapeDataString(value)); | |||
There was a problem hiding this comment.
I do not think this change is safe, as we are stopping decoding for all options and that options are available via public API, not just for building the resolved connection string.
There was a problem hiding this comment.
I would suggest either introduce new private collection to contain the unprocessed options (like a _rawOptions), or DO NOT escape/unescape only authmechanismproperties option to mimic what ParseOption does.
…eters from SRV connection string
| @@ -697,16 +697,13 @@ private ConnectionString BuildResolvedConnectionString(ConnectionStringScheme re | |||
| private void ExtractScheme(Match match) | |||
| { | |||
| var schemeGroup = match.Groups["scheme"]; | |||
| if (schemeGroup.Success) | |||
| if (schemeGroup.Success && schemeGroup.Value == "mongodb+srv") | |||
There was a problem hiding this comment.
Unrelated change, but I looked at it :)
| @@ -925,7 +922,7 @@ private void ParseOption(string name, string value) | |||
| _authMechanism = value; | |||
| break; | |||
| case "authmechanismproperties": | |||
| foreach (var property in GetAuthMechanismProperties(name, value)) | |||
| foreach (var property in GetAuthMechanismProperties(name, value, _isInternalRepresentation)) | |||
There was a problem hiding this comment.
_isInternalRepresentation has a strange name, but it's set to true only by one constructor. And this constructor is only called by BuildResolvedConnectionString.
…eters from SRV connection string