-
Notifications
You must be signed in to change notification settings - Fork 33
DOCSP-48712 edit for proper user/pw info #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48712 edit for proper user/pw info #480
Conversation
✅ Deploy Preview for docs-golang ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back to you with a question
@@ -105,12 +105,12 @@ issues when attempting to connect to MongoDB. | |||
For more information about connection strings, | |||
see :ref:`Connection URI <golang-connection-uri>` in the Connection Guide. | |||
|
|||
If your connection string contains a username and password, ensure that they | |||
If your connection string contains a database username and database password, ensure that they |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: isn't this true about non-DB usernames and passwords too? Same question for line 113 in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can connection strings contain non-DB username and pws? I was reading the golang connection guide that states that "the connection string contains your database username and, if you are using password-based authentication, your password," so I was under the impression that the connection string can only contain a db user and not any other type of user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of the enterprise auth mechanisms, which use Kerberos principal and LDAP username for the username
parameter.
I would also hope that anyone coming to this page for help would recognize that username
and password
apply to them even if they're using their db username/password.
For those reasons, I'd vote to keep username
and password
for this troubleshooting section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with that! i'll change them back 👍 thanks for the explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.17 v1.17
# Navigate to the new working tree
cd .worktrees/backport-v1.17
# Create a new branch
git switch --create backport-480-to-v1.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da8780df22770b0793d1e1e04cef41c158b945b7
# Push it to GitHub
git push --set-upstream origin backport-480-to-v1.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.0 v2.0
# Navigate to the new working tree
cd .worktrees/backport-v2.0
# Create a new branch
git switch --create backport-480-to-v2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da8780df22770b0793d1e1e04cef41c158b945b7
# Push it to GitHub
git push --set-upstream origin backport-480-to-v2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v2.1 v2.1
# Navigate to the new working tree
cd .worktrees/backport-v2.1
# Create a new branch
git switch --create backport-480-to-v2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da8780df22770b0793d1e1e04cef41c158b945b7
# Push it to GitHub
git push --set-upstream origin backport-480-to-v2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v2.1 Then, create a pull request where the |
…entials DOCSP-48712 edit for proper user/pw info
Merge pull request #480 from shuangela/DOCSP-48712-update-credentials
…entials DOCSP-48712 edit for proper user/pw info
Merge pull request #480 from shuangela/DOCSP-48712-update-credentials
…entials DOCSP-48712 edit for proper user/pw info
Merge pull request #480 from shuangela/DOCSP-48712-update-credentials
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48712
Staging - https://deploy-preview-480--docs-golang.netlify.app/connection-troubleshooting/
https://deploy-preview-480--docs-golang.netlify.app/usage-examples/
Self-Review Checklist