Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.3 #760

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Support PHP 8.3 #760

merged 8 commits into from
Nov 22, 2023

Conversation

frederikbosch
Copy link
Member

No description provided.

@frederikbosch frederikbosch mentioned this pull request Nov 17, 2023
@frederikbosch
Copy link
Member Author

frederikbosch commented Nov 17, 2023

We need phpspec/phpspec#1450 to be fixed before we can really support PHP8.3. I might merge it even if PHPSpec is not ready yet.

@frederikbosch
Copy link
Member Author

Also need to get these docs fixed.

@ruudk
Copy link
Contributor

ruudk commented Nov 17, 2023

I wish this project did not depend on PHPSpec. Every year it's the same blocker 😢
Wouldn't it make sense to use plain PHPUnit? https://tomasvotruba.com/blog/2019/03/21/how-to-instantly-migrate-phpspec-to-phpunit

@frederikbosch
Copy link
Member Author

Yeah, I agree. That's why I said I would even merge it despite lack of phpspec support. I would not mind getting rid of it at all. If you see time to come up with a PR, I would very much welcome it.

With rector it might be less work than we think. Although, moving to tests folder might conflict with our current phpunit tests.

@ruudk
Copy link
Contributor

ruudk commented Nov 17, 2023

What if we drop the specs completely? Isn't it covered by unit tests already?

@frederikbosch
Copy link
Member Author

I would only do such a thing if we would know, rather than think it does.

@frederikbosch
Copy link
Member Author

I have increased the test coverage of the unit tests. Now every file is tested, and has a coverage of above 80%, with the far majority having a coverage of 90%+. Maybe we should indeed drop the phpsec. I am giving it another thought later this week, before really removing it.

@frederikbosch
Copy link
Member Author

I think this is ready to go

@ruudk
Copy link
Contributor

ruudk commented Nov 21, 2023

Wow, great that PHPSpec has been removed. This will make future maintenance and contributions easier! 🎉

@frederikbosch
Copy link
Member Author

We could also drop PHP 8.0, maybe in a separate PR. Security support for 8.0 will be dropped in a few days. If people want to use MoneyPHP with PHP 8.0 they can use <= ~4.2.0, while PHP 8.3 would require ^4.3.0.

@ruudk
Copy link
Contributor

ruudk commented Nov 21, 2023

If a PHP version is EOL, we can drop it indeed. But please do it in a separate PR / release 😁

@frederikbosch frederikbosch merged commit 5e71a0f into master Nov 22, 2023
18 checks passed
@frederikbosch frederikbosch deleted the php83 branch November 22, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants