address psalm warnings from version bump

moneyphp · Jul 19, 2023 · 50acc09 · 50acc09
1 parent 158c9d7
commit 50acc09
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 7 deletions.
diff --git a/src/Calculator/BcMathCalculator.php b/src/Calculator/BcMathCalculator.php
@@ -221,6 +221,6 @@ public static function mod(string $amount, string $divisor): string
             throw InvalidArgumentException::moduloByZero();
         }
 
-        return bcmod($amount, $divisor) ?? '0';
+        return bcmod($amount, $divisor);
     }
 }
diff --git a/src/Currencies/CryptoCurrencies.php b/src/Currencies/CryptoCurrencies.php
@@ -81,15 +81,12 @@ private function getCurrencies(): array
      *     symbol: non-empty-string,
      *     minorUnit: positive-int|0
      * }>
-     *
-     * @psalm-suppress MoreSpecificReturnType do not specify all keys and values
      */
     private function loadCurrencies(): array
     {
         $file = __DIR__ . '/../../resources/binance.php';
 
         if (is_file($file)) {
-            /** @psalm-suppress LessSpecificReturnStatement */
             return require $file;
         }
 

diff --git a/src/Currencies/ISOCurrencies.php b/src/Currencies/ISOCurrencies.php
@@ -101,15 +101,12 @@ private function getCurrencies(): array
      *     minorUnit: positive-int|0,
      *     numericCode: positive-int
      * }>
-     *
-     * @psalm-suppress MoreSpecificReturnType do not specify all keys and values
      */
     private function loadCurrencies(): array
     {
         $file = __DIR__ . '/../../resources/currency.php';
 
         if (is_file($file)) {
-            /** @psalm-suppress LessSpecificReturnStatement */
             return require $file;
         }
 

diff --git a/src/PHPUnit/Comparator.php b/src/PHPUnit/Comparator.php
@@ -88,6 +88,10 @@ public function assertEquals(
                 throw new ComparisonFailure($expected, $actual, $this->formatter->format($expected), $this->formatter->format($actual), 'Failed asserting that two Money objects are equal.');
             }
 
+            /**
+             * @psalm-suppress TooManyArguments
+             * @psalm-suppress InvalidArgument
+             */
             throw new ComparisonFailure($expected, $actual, $this->formatter->format($expected), $this->formatter->format($actual), false, 'Failed asserting that two Money objects are equal.');
         }
     }