bump master to v0.18.4.0 #320
Merged
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, the master branch can build against v0.18.3.4. It's probably wise to pin the latest Monero build in the Dockerfile going forward, at least for the master branch. |
|
Maybe this PR can also pin to 0.18.4.0 and be merged after that's released, and a different PR can pin to 0.18.3.2 and be merged immediately. |
|
Thank you! |
|
Git command to cherry pick commit from the PR, if anyone is interested. |
|
@moneroexamples v0.18.4.0 is tagged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes build for release-v0.18 (v0.18.4.0 will be tagged soon, and will require this fix)
on another note: might be a good idea to build against tags (v0.18.4.0) instead of the branch (release-v0.18)
cherrypicked from devel