Make Tooltip position-aware #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `horizontalPosition` and `verticalPosition` props to the Tooltip component, so that custom Tooltip components can use that information for things like rendering custom arrows.
This was referenced Sep 14, 2021
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
horizontalPositionandverticalPositionprops to the Tooltip component, so that custom Tooltip components can use that information for things like rendering custom arrows.(In my particular case, we wanted to render white text directly over the mask, and render a white SVG arrow that points in the correct direction for the highlighted element.)
Part of a series of PRs for more flexible styling:
nextOnOutsideClickoption #238