Require API key in production sender

Author: Joshua Wood

lib/honeybadger/sender.rb

@@ -34,12 +34,17 @@ def initialize(options = {})
     #
     # Returns error id from successful response
     def send_to_honeybadger(notice)
+      if api_key.nil?
+        log(:error, "API key not found.")
+        return nil
+      end
+
       data = notice.is_a?(String) ? notice : notice.to_json
 
       http     = setup_http_connection
       headers  = HEADERS
 
-      headers.merge!({ 'X-API-Key' => api_key}) unless api_key.nil?
+      headers.merge!({ 'X-API-Key' => api_key})
 
       response = begin
                    http.post(url.path, data, headers)

test/unit/sender_test.rb

@@ -71,6 +71,12 @@ def stub_http(options = {})
     assert_equal nil, send_exception(:secure => false)
   end
 
+  should "log missing API key and return nil" do
+    sender = build_sender({ :api_key => nil })
+    sender.expects(:log).with(:error, includes('API key'))
+    assert_equal nil, send_exception(:sender => sender, :secure => false)
+  end
+
   should "should log success" do
     http = stub_http
     sender = build_sender