Fail gracefully when sender hasn't been configured. honeybadger-io#25

Author: Joshua Wood

lib/honeybadger/notice.rb

@@ -125,8 +125,10 @@ def initialize(args)
 
     # Public: Send the notice to Honeybadger using the configured sender
     #
-    # Returns a reference to the error in Honeybadger
+    # Returns a reference to the error in Honeybadger, false if sender isn't
+    # configured
     def deliver
+      return false unless Honeybadger.sender
       Honeybadger.sender.send_to_honeybadger(self)
     end
 

test/unit/notice_test.rb

@@ -22,14 +22,26 @@ def stub_request(attrs = {})
                       :env         => { 'three' => 'four' } }.update(attrs))
   end
 
-  should "deliver to sender" do
-    sender = stub_sender!
-    notice = build_notice
-    notice.stubs(:to_json => { :foo => 'bar' })
+  context '#deliver' do
+    context 'sender is configured' do
+      should "deliver to sender" do
+        sender = stub_sender!
+        notice = build_notice
+        notice.stubs(:to_json => { :foo => 'bar' })
+
+        notice.deliver
 
-    notice.deliver
+        assert_received(sender, :send_to_honeybadger) { |expect| expect.with(notice) }
+      end
+    end
 
-    assert_received(sender, :send_to_honeybadger) { |expect| expect.with(notice) }
+    context 'sender is not configured' do
+      should "return false" do
+        notice = build_notice
+        Honeybadger.sender = nil
+        assert_equal false, notice.deliver
+      end
+    end
   end
 
   should "generate json from as_json template" do