Skip to content

fix(rsbuild-plugin): support other output formats #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Feb 28, 2025

Description

This pull request includes several changes to the @module-federation/rsbuild-plugin and configuration files to enhance functionality and improve plugin behavior. The most important changes include the addition of a new option to force Module Federation on all formats, adjustments to chunk loading settings, and updates to configuration files to include the rsbuild-plugin package.

Enhancements to @module-federation/rsbuild-plugin:

  • Added forceMfOnAllFormats option to ModuleFederationOptions to allow overriding the default format check and enable Module Federation on all formats (packages/rsbuild-plugin/src/cli/index.ts).
  • Updated pluginModuleFederation function to respect the forceMfOnAllFormats option and prevent setting chunkLoading to jsonp when chunkFormat is module (packages/rsbuild-plugin/src/cli/index.ts). [1] [2] [3] [4]

Configuration file updates:

  • Added .changeset entries to document the new forceMfOnAllFormats option and the change in chunk loading behavior (.changeset/breezy-tools-serve.md, .changeset/lovely-waves-draw.md). [1] [2]
  • Updated .cursorignore to include the rsbuild-plugin package and its contents (.cursorignore). [1] [2]

Resolved runtime errors when chunk format is esm module

Related Issue

module-federation/module-federation-examples#4342

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: c53cfe0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@module-federation/rsbuild-plugin Patch
@module-federation/modern-js Patch
@module-federation/runtime Patch
@module-federation/enhanced Patch
@module-federation/rspack Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/sdk Patch
@module-federation/runtime-tools Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/dts-plugin Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/devtools Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/retry-plugin Patch
@module-federation/data-prefetch Patch
@module-federation/error-codes Patch
@module-federation/inject-external-runtime-core-plugin Patch
@module-federation/runtime-core Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit c53cfe0
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67cfe27be4b33d000894571d
😎 Deploy Preview https://deploy-preview-3558--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy changed the title fix(rsbuild-plugin): do not set jsonp chunk loading when chunk format… fix(rsbuild-plugin): support other output formats Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants