-
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(rsbuild-plugin): support other output formats #3558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ScriptedAlchemy
wants to merge
4
commits into
main
Choose a base branch
from
rsbuild-esm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c53cfe0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
douglaszaltron
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the
@module-federation/rsbuild-plugin
and configuration files to enhance functionality and improve plugin behavior. The most important changes include the addition of a new option to force Module Federation on all formats, adjustments to chunk loading settings, and updates to configuration files to include thersbuild-plugin
package.Enhancements to
@module-federation/rsbuild-plugin
:forceMfOnAllFormats
option toModuleFederationOptions
to allow overriding the default format check and enable Module Federation on all formats (packages/rsbuild-plugin/src/cli/index.ts
).pluginModuleFederation
function to respect theforceMfOnAllFormats
option and prevent settingchunkLoading
tojsonp
whenchunkFormat
ismodule
(packages/rsbuild-plugin/src/cli/index.ts
). [1] [2] [3] [4]Configuration file updates:
.changeset
entries to document the newforceMfOnAllFormats
option and the change in chunk loading behavior (.changeset/breezy-tools-serve.md
,.changeset/lovely-waves-draw.md
). [1] [2].cursorignore
to include thersbuild-plugin
package and its contents (.cursorignore
). [1] [2]Resolved runtime errors when chunk format is esm module
Related Issue
module-federation/module-federation-examples#4342
Types of changes
Checklist