Upgrading Mirage Packages #646
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows VPNkit to be build with OCaml 5+ Signed-off-by: Patrick Ferris <[email protected]>
patricoferris
force-pushed
the
updating-mirage
branch
from
e493f00 to
24caf7a
Compare
hannesm
reviewed
Feb 27, 2025
hannesm
reviewed
Feb 27, 2025
| Icmpv4_wire.set_icmpv4_id raw id'; | ||
| Icmpv4_wire.set_icmpv4_csum raw 0; | ||
| Icmpv4_wire.set_icmpv4_csum raw (Tcpip_checksum.ones_complement raw); | ||
| Cstruct.BE.set_uint16 raw 5 id'; (* TODO: Upstream *) |
There was a problem hiding this comment.
nice catch, please upstream the missing bindings (from when I removed ppx_cstruct)
hannesm
reviewed
Feb 27, 2025
src/hostnet_test/dune
Outdated
| @@ -2,5 +2,5 @@ | |||
| (name main) | |||
| (libraries hostnet cmdliner alcotest logs.fmt protocol-9p mirage_dns | |||
| mirage-clock-unix charrua-client.mirage forwarder sha | |||
| mirage-random-stdlib arp.mirage) | |||
| mirage-random-stdlib arp.mirage tcpip.ipv6 mirage-crypto-rng.unix) | |||
There was a problem hiding this comment.
the mirage-random-stdlib is to be avoided (deprecated) and shouldn't be needed. Just use Mirage_crypto_rng directly (and Mirage_crypto_rng_unix.use_default ()).
Signed-off-by: Patrick Ferris <[email protected]>
hannesm
reviewed
Feb 28, 2025
Comment on lines
63
to
65
| "mirage-clock" {>= "4.0.0"} | ||
| "mirage-clock-unix" {>= "4.0.0"} | ||
| "mirage-random" {>= "3.0.0"} |
There was a problem hiding this comment.
Suggested change
| "mirage-clock" {>= "4.0.0"} | |
| "mirage-clock-unix" {>= "4.0.0"} | |
| "mirage-random" {>= "3.0.0"} | |
| "mirage-sleep" {>= "4.0.0"} | |
| "mirage-mtime" {>= "5.0.0"} |
hannesm
reviewed
Feb 28, 2025
| @@ -52,9 +52,8 @@ depends: [ | |||
| "mirage-net" {>= "4.0.0"} | |||
| "mirage-time" {>= "3.0.0"} | |||
There was a problem hiding this comment.
Suggested change
| "mirage-time" {>= "3.0.0"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few remarks about this PR:
This PR will depend on updating hvsock (mirage/ocaml-hvsock#69) and ocaml-9p (mirage/ocaml-9p#146).
I was also struggling to build on nixos, but I'll work on that.