Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a custom equals parameter for observable collections #970

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 15, 2023

Describe the changes proposed in this Pull Request.

Allow a custom equals parameter for observable collections, like observable stream, observable and computed .

#771
#482

If the PR fixes a specific issue, reference the issue with Fixes #.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 15, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d13d88d

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #970 (d13d88d) into main (d14a27e) will decrease coverage by 0.62%.
Report is 3 commits behind head on main.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   99.00%   98.38%   -0.62%     
==========================================
  Files          57       57              
  Lines        2005     2043      +38     
==========================================
+ Hits         1985     2010      +25     
- Misses         20       33      +13     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 97.69% <83.33%> (-0.88%) ⬇️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/api/observable_collections/observable_list.dart 99.20% <90.00%> (-0.80%) ⬇️
...src/api/observable_collections/observable_map.dart 98.41% <89.47%> (-1.59%) ⬇️
...src/api/observable_collections/observable_set.dart 91.17% <76.92%> (-8.83%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14a27e...d13d88d. Read the comment docs.

@amondnet amondnet force-pushed the add-equals-observable-collection branch from 851e078 to d13d88d Compare December 15, 2023 10:30
@amondnet amondnet self-assigned this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant