Fix plamo2 model to use rms_norm #1308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitmul
force-pushed
the
mitmul/fix-plamo2
branch
from
5a54068 to
08a8dd2
Compare
|
I removed the redundant parts of the code because, as mentioned in the comment here, sliding window attention should be implemented using RotatingKVCache rather than being directly incorporated into the model code. But I still see some differences between MLX's layer norm and the |
mitmul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for fixing my messy code in #1283. However, it seems that some parts of the model code have changed, leading to slightly different behavior from the original. This PR aims at fixing it.