Distributed support cifar #1301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
reviewed
Feb 26, 2025
Comment on lines
+57
to
+60
| mx.eval(stats, count) | ||
| count = count.item() | ||
|
|
||
| return [s / count for s in stats.tolist()] |
There was a problem hiding this comment.
Suggested change
| mx.eval(stats, count) | |
| count = count.item() | |
| return [s / count for s in stats.tolist()] | |
| return (stats / count).tolist() |
There was a problem hiding this comment.
Haha I don't know what I was thinking 🤦♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if it ended up being a bit verbose and out of scope. Perhaps it makes sense to have more dedicated DDP training examples.
It also only works on master as I am using
mx.distributed.all_sum(scalar)