Experimental support for catching serialization errors #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
added a commit
that referenced
this pull request
Feb 11, 2020
This reverts commit 690e050.
mitsuhiko
added a commit
that referenced
this pull request
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to catch serialization errors and report them across the process boundary. This seems quite insane because it calls
send()twice. I'm also currently experiencing all kinds of errors being reported on my mac but I'm not sure if this is related to this change.This also adds a JSON wrapper so that bincode incompatible values can be send across.
Opened an upstream issue in ipc-channel: servo/ipc-channel#257