Build app into wheel #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
reviewed
Jul 14, 2023
- info.plist identifier did not accept "_" char, so it did not run (ErrSecInternal) - create .icns and add them to info.plist - Tested in multiple way (really a lot ways) the embed_plist crate but it does not work in this case because macos Security extension needs GUI - some naming improvements
this because before we add the cert and then we trust it with external truster app
emanuele-em
force-pushed
the
build_app_into_wheel
branch
from
9f8cc8f
to
f853327
Compare
emanuele-em
force-pushed
the
build_app_into_wheel
branch
from
cfe1f20
to
ae77edd
Compare
mhils
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR that updates ffi/build.rs to copy over the app into the wheel.