macos redirector app + CI #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhils
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Let's untangle this a bit: In this PR, let's only add the macos-redirector app + a GitHub Actions CI to build it.
build.rs is meant to copy the final (compiled) app into mitmproxy_rs so that it's included as part of the wheel. Copying to /Applications will not help us on the target device. Let's leave build.rs out of the picture here for this PR. :-)
emanuele-em
force-pushed
the
macos-redirector
branch
from
b4334a5
to
26e1be8
Compare
emanuele-em
force-pushed
the
macos-redirector
branch
from
616ac2f
to
98b8e0b
Compare
emanuele-em
force-pushed
the
macos-redirector
branch
from
bb3fac1
to
aa2e58e
Compare
emanuele-em
force-pushed
the
macos-redirector
branch
from
47b6bae
to
fb9e6a2
Compare
mhils
reviewed
Jul 20, 2023
.github/workflows/ci.yml
Outdated
| - if: ${{ runner.os == 'macOS' }} | ||
| run: | | ||
| xcodebuild -project macos-redirector/MitmproxyAppleTunnel.xcodeproj -destination 'platform=macOS' CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED="NO" CODE_SIGN_ENTITLEMENTS="" CODE_SIGNING_ALLOWED="NO" -scheme MitmproxyAppleExtension build | ||
| xcodebuild -project macos-redirector/MitmproxyAppleTunnel.xcodeproj -destination 'platform=macOS' CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED="NO" CODE_SIGN_ENTITLEMENTS="" CODE_SIGNING_ALLOWED="NO" -scheme MitmproxyAppleTunnel build |
There was a problem hiding this comment.
This means binaries will not be signed at all, including for builds from the main branch? That needs to happen for them to work, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pull request includes the following:
.appfilebuild.rsTo copy the executable to the right place so it can be launched properly