Audio track volume control and SoundPlayer ducking #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-missing-folders Allow missing mode folders in production mode (cherry picked from commit 90f0917)
|
Wheel builder is failing on this (and previous) PRs but I've run all the tests locally and they check out. Proceeding to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio Track Volume Control
This PR extends the audio tracks (defined in
sound_system: tracks:) to have discrete volume levels that can be controlled from the Service Audio Menu (missionpinball/mpf#1743). Each track can already have a separate volume level, but with this PR that level is adjustable via menu and automatically persisted as a machine var, to allow fine-tuning of relative track levels during gameplay.SoundPlayer Ducking
This PR adds support for
duckingarguments in SoundPlayer, so ducking can be defined at the player level instead of on each individual sound file separately. This is intended as a broad-strokes approach to provide basic ducking quickly, and is not nearly as accurate as defining ducking to each sound specifically. With this in mind, for any sound that has its ownducking:defined that sound's ducking will take priority over the SoundPlayer ducking.SlidePlayer Logging
This PR reduces the log level of the SlidePlayer from INFO to DEBUG, because during a game lots of slides are played and the logging for slides is bulky. SlidePlayer logs to the machine log, so it's log level cannot be configured separately from the general machine. After this change, the SlidePlayer logs will still appear in verbose mode.