Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback config in Global Settings page #85

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eugenechantk
Copy link

I added some explanations to toggle the feedback section + repo in the global settings page

Comment on lines +432 to +459
### Repo
<ResponseField name="repo" type="Repo">
Specify the repo where you store your source documentations

<Expandable title="Repo">
<ResponseField name="github" type="github_repo">
Information about your documentation Github Repo
<Expandable title="Redirect">
<ResponseField name="owner" type="string">
</ResponseField>
<ResponseField name="repo" type="string">
</ResponseField>
<ResponseField name="deployBranch" type="string">
The deployment branch name of your documentation
</ResponseField>
<ResponseField name="contentDirectory" type="string">
The name of the root directory where your documentation is stored in the Github repo
</ResponseField>
<ResponseField name="isPrivate" type="boolean">
Whether your documentation repo is private.

Note: if you enabled Suggest Edits or Raise Issue in the feedback section, they would only work if your documentation Github repo is public.
</ResponseField>
</Expandable>
</ResponseField>
</Expandable>
</ResponseField>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little confusing, but repo isn't actually configured in the mint.json. It's configured somewhere else, not exactly sure where though

Comment on lines +407 to +430
### Feedbacks

<ResponseField name="feedback" type="Feedback">
Configurations to add a feedback section to the end of every page

<Expandable title="Redirect">
<ResponseField name="suggestEdit" type="boolean">
Enable a "Suggest Edit" button that creates an edit to the source documentation in your documentation Github repo, provided that the Github repo is public

</ResponseField>
<ResponseField name="raiseIssue" type="boolean">
Enable a "Raise Issue" button that creates an issue in your documentation Github repo, provided that the Github repo is public

</ResponseField>

</ResponseField>
<ResponseField name="review" type="boolean">
Enable a review section where readers can rate if your document is useful or not

</ResponseField>

</Expandable>

</ResponseField>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section already exists, see line 263, just add to that section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants