Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Poetry #11

wants to merge 1 commit into from

Conversation

AndreyeuIvan
Copy link

How to use poetry:

  1. pip3 install poetry\n 2. poetry add requests(as example) in order to add requerements into poetry.

@AndreyeuIvan
Copy link
Author

Added poetry.

shurph
shurph reviewed Jul 14, 2020
View reviewed changes
Copy link
Member

@shurph shurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет, Иван,
Спасибо за пул реквест!
Есть некоторые моменты, которые можно улучшить. Чуть позже оставлю комментарии по этим моментам.

shurph
shurph requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@shurph shurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Похоже, все файлы в этом PR помещены в директорию pyvideo_scrape_mpm/. Надо бы их всё-таки в самый корень репозитория поместить.

shurph
shurph requested changes Jul 14, 2020
View reviewed changes
Copy link
Member

@shurph shurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В проекте уже есть файл README.md, поэтому README.rst не нужен.

@shurph
Copy link
Member

shurph commented Oct 18, 2020

Current proposed changes can't be merged as is. So issue #4 is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shurph shurph shurph requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreyeuIvan @shurph