SDIT-2488 Upgrade to Spring Boot 3.4.2 #350
Conversation
release-notes/7.x.md
Outdated
| ## Breaking changes | ||
|
|
||
| ### ktlint | ||
|
|
||
| This Spring Boot release (3.4.2) breaks the ktlint Spring Boot Plugin as detailed in this issue: https://github.com/JLLeitschuh/ktlint-gradle/issues/809 | ||
|
|
||
| To fix this we've upgraded the version of ktlint used to the lowest version that works around this bug. Unfortunately this has broken `ktlintCheck` on most projects. | ||
|
|
||
| Action required: run command `./gradlew ktlintFormat` |
There was a problem hiding this comment.
As there is an action required by users I've gone to a new major version. I think this is appropriate but would appreciate feedback.
| // TODO The ktlint version applied by the ktlint plugin needs pinning to 1.4.1 to workaround this issue: https://github.com/JLLeitschuh/ktlint-gradle/issues/809 | ||
| // TODO Once the issue is solved we should stop pinning the version and take the default version provided by the ktlint plugin | ||
| private const val KTLINT_VERSION = "1.4.1" |
There was a problem hiding this comment.
This is the breaking change. I see that another HMPPS dev (@wood-n) had the same problem with a recent upgrade so I think I'm doing the right thing.
| @@ -30,7 +30,7 @@ fun isNonStable(version: String): Boolean { | |||
| } | |||
|
|
|||
| group = "uk.gov.justice.hmpps.gradle" | |||
| version = "6.1.2" | |||
| version = "7.0.0-beta" | |||
There was a problem hiding this comment.
As this is a breaking change I've decided to go for a beta version. I'm not sure this is totally necessary but the breaking change made me twitchy,.
build.gradle.kts
Outdated
| id("se.patrikerdes.use-latest-versions") version "0.2.18" | ||
| id("org.owasp.dependencycheck") version "8.4.3" | ||
| id("org.owasp.dependencycheck") version "12.0.1" |
There was a problem hiding this comment.
I've been avoiding this upgrade as it requires API keys and a local caching strategy
release-notes/7.x.md
Outdated
|
|
||
| ### ktlint | ||
|
|
||
| This Spring Boot release (3.4.2) breaks the ktlint Spring Boot Plugin as detailed in this issue: https://github.com/JLLeitschuh/ktlint-gradle/issues/809 |
There was a problem hiding this comment.
don't think this is the spring boot release, but more the upgrade to kotlin 2.1 - see JLLeitschuh/ktlint-gradle#815
release-notes/7.x.md
Outdated
|
|
||
| This Spring Boot release (3.4.2) breaks the ktlint Spring Boot Plugin as detailed in this issue: https://github.com/JLLeitschuh/ktlint-gradle/issues/809 | ||
|
|
||
| To fix this we've upgraded the version of ktlint used to the lowest version that works around this bug. Unfortunately this has broken `ktlintCheck` on most projects. |
There was a problem hiding this comment.
I wouldn't call ktlintCheck broken, more that it fails due to new formatting issues?
| @@ -5,7 +5,7 @@ import org.gradle.api.tasks.Copy | |||
| import uk.gov.justice.digital.hmpps.gradle.ConfigManager | |||
|
|
|||
| private const val APP_INSIGHTS_VERSION = "3.6.2" | |||
| const val OPENTELEMETRY_VERSION = "1.43.0" | |||
| const val OPENTELEMETRY_VERSION = "1.46.0" | |||
There was a problem hiding this comment.
I've tended to keep this version the same as the version used by app insights - see https://github.com/microsoft/ApplicationInsights-Java/blob/3.6.2/dependencyManagement/build.gradle.kts#L14
No description provided.