Feature/openid client config #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abroa01
commented
Nov 19, 2024
abroa01
commented
- Created the openid version of the webchart-oauth-example.
- Made a video showing the flow of the application and uploaded on YouTube https://youtu.be/jqhS8GgddO4
- changed the package.json file to
- handle both commonJS as well as ES modules
- change the start and test script to handle and give user an option to run either the default app (webchart-oauth-example.js i.e., that uses simple Oauth) or OpenID app (webchart-example_openid.mjs i.e., that uses new Openid code)
- created another puppeteer-test_openid.js to test the webchart-example_openid.mjs
- Replaced `var` with `const` and `let` for proper variable scoping. - Switched to ES6 module syntax and used destructuring in imports. - Simplified control flow by using early returns instead of `else if` chains. - Wrapped server logic in `try-catch` blocks to handle unexpected errors. - Added JSDoc comments to document functions and enhance readability. - Utilized the `URL` module for reliable URL parsing instead of string manipulation. - Improved logging consistency using `console.error` for errors and `console.log` for standard logs.
Updated the client id and hardcoded it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.