feat: add page iterator #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
requested changes
Feb 18, 2025
baywet
reviewed
Feb 20, 2025
baywet
reviewed
Feb 20, 2025
src/tasks/PageIterator.ts
Outdated
| * @enum | ||
| * Enum representing the state of the iterator | ||
| */ | ||
| export enum PagingState { |
There was a problem hiding this comment.
I'd recommend against using enums since they are slowly going away and some ts configurations /deno/etc... now prohibit them. How about a union of string values instead?
src/tasks/PageIterator.ts
Outdated
| * @class | ||
| * Class for PageIterator | ||
| */ | ||
| export class PageIterator<T extends Parsable, C extends Parsable> { |
There was a problem hiding this comment.
missing doc comments for the type parameters
| const requestInformation = new RequestInformation(); | ||
| requestInformation.httpMethod = HttpMethod.GET; | ||
| requestInformation.urlTemplate = this.getOdataNextLink(); | ||
| requestInformation.headers.addAll(this.headers); | ||
| if (this.options) { | ||
| if (this.options.headers) { |
There was a problem hiding this comment.
Should we remove the this.headers property now that you have this here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6