feat: Add large file upload #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkodev
force-pushed
the
feat/large-file-upload
branch
from
e1f72ed to
b374a1c
Compare
| * @interface | ||
| * Signature to represent the upload session response | ||
| */ | ||
| export interface UploadSessionResponse extends Parsable { |
There was a problem hiding this comment.
I don't think this is needed. Its the same as the UploadSession type
| * @returns {Promise<UploadResult<T> | undefined>} - The result of the upload. | ||
| * @throws {Error} If the maximum number of retries is reached. | ||
| */ | ||
| private async uploadWithRetry(uploadSlice: UploadSlice<T>, maxTries = 3): Promise<UploadResult<T> | undefined> { |
There was a problem hiding this comment.
The method is private and unused. Any chance this is intentional?
baywet
reviewed
Feb 21, 2025
| * @throws {Error} If the request fails. | ||
| */ | ||
| public async updateSession() { | ||
| const requestInformation = new RequestInformation(HttpMethod.GET, this.Session.uploadUrl!); |
There was a problem hiding this comment.
avoid bang operators, they lead to nasty bugs.
instead, validate the value, and throw an explicit error
| * @param {number} ms - The number of milliseconds to sleep. | ||
| * @returns {Promise<void>} A promise that resolves after the specified time. | ||
| */ | ||
| private sleep(ms: number): Promise<void> { |
There was a problem hiding this comment.
same comment about this method if the retry one gets deleted
| private async readSection(stream: ReadableStream<Uint8Array>, start: number, end: number): Promise<ArrayBuffer> { | ||
| const reader = stream.getReader(); | ||
| let bytesRead = 0; | ||
| const chunks: Uint8Array[] = []; |
There was a problem hiding this comment.
as far as I understand this implementation, we're reading all the file at once and putting it all in memory. And this every time we upload a chunk. This is going to cause significant IOPS and memory pressure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add large file upload
Resolve #7