Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add direct dependency on System.Text.Json #3075

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Jan 17, 2025

part of #2774

Unblocks

  • conflicts with ExchangeOnlineManagement caused by using System.Text.Json 6.x
  • security update since v6.x has CVEs

EXO failing with a different error that doesn't signal conflicts, reached out to partner team to clarify
Update: Issue was in my app registration permissions for EXO
Reference docs to set up app-only auth with EXO: https://learn.microsoft.com/en-us/powershell/exchange/app-only-auth-powershell-v2?view=exchange-ps

Importing MgGraph before EXO & Az.Accounts
image (3)

Import EXO before MgGraph & Az.Accounts
image (4)

@Ndiritu Ndiritu force-pushed the feat/upgrade-system-text-json branch 2 times, most recently from 9c0389c to df75682 Compare January 20, 2025 12:42
@Ndiritu Ndiritu force-pushed the feat/upgrade-system-text-json branch from df75682 to 7324354 Compare January 21, 2025 09:06
@Ndiritu Ndiritu marked this pull request as ready for review January 21, 2025 09:06
@Ndiritu Ndiritu requested a review from a team as a code owner January 21, 2025 09:06
@Ndiritu Ndiritu self-assigned this Jan 21, 2025
@Ndiritu Ndiritu merged commit 9f9b7fa into dev Jan 22, 2025
6 checks passed
@Ndiritu Ndiritu deleted the feat/upgrade-system-text-json branch January 22, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants