Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fluent v9 upgrade accessibility issues #3593

Open
wants to merge 12 commits into
base: feat/fluent-v9-upgrade
Choose a base branch
from

Conversation

ElinorW
Copy link
Contributor

@ElinorW ElinorW commented Feb 11, 2025

Overview

Fixes #3592

Demo

Notes

Known issue regarding the aria-hidden-focus brought about by the tabs
image

the fluent team has shared this in regard to that issue on their Wiki
image

Testing Instructions

  • How to test this PR
  • Prefer bulleted description
  • Start after checking out this branch
  • Include any setup required, such as bundling scripts, restarting services, etc.
  • Include test case, and expected output

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

@ElinorW ElinorW marked this pull request as ready for review February 21, 2025 13:09
@ElinorW ElinorW requested a review from a team as a code owner February 21, 2025 13:09
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-wave-0c4fb390f-3593.eastus2.4.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant