Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate response section to fluent UI v9 #3473

Merged
merged 89 commits into from
Feb 13, 2025
Merged

feat: migrate response section to fluent UI v9 #3473

merged 89 commits into from
Feb 13, 2025

Conversation

musale
Copy link
Contributor

@musale musale commented Dec 2, 2024

Closes #3446
Closes #3447
Closes #3448

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

musale added 10 commits December 10, 2024 19:14
@musale
feat: add GraphToolkitV9 component and integrate it into pivot items
719a95e
@musale
refactor: remove unused styledGraphToolkit definition from GraphToolk…
48651dc 
…itV9 component
@musale
refactor: update adaptive cards lookup and improve error handling in …
3e24781 
…adaptive card utilities
@musale
refactor: clean up imports and reorganize state selection in Adaptive…
f8e4032 
…CardV9 component
@musale
WIP: back from leave
a1609c5
@musale
Merge branch 'feat/fluent-v9-upgrade' into feat/response-v9
ca176fa
@musale
refactor: Update imports and clean up code formatting in QueryRespons…
4fa32da 
…e and App components
@musale
refactor: Simplify QueryResponse component by returning GetPivotItems…
64a4424 
… directly
@musale
refactor: Restore GetPivotItems usage and reintroduce QueryResponse l…
163aa75 
…ayout
@musale
refactor: Introduce QueryResponseV9 component and update App to use it
6665ff1
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@musale musale mentioned this pull request Jan 9, 2025
Closed
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@musale musale requested a review from Mnickii February 12, 2025 11:25
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

ElinorW
ElinorW reviewed Feb 12, 2025
View reviewed changes
@ElinorW
Copy link
Contributor

ElinorW commented Feb 12, 2025

Noticed a few minor UI issues

  1. Odata link seems to be pushed to the right
    image
  2. Method drop down expands when the Autocomplete area has an error
    image

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@ElinorW
Copy link
Contributor

ElinorW commented Feb 12, 2025

Also the close button on the expand dialog seems to be slightly misplaced
image

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@Mnickii
Copy link
Contributor

Mnickii commented Feb 12, 2025

For larger screens, the search resources button is not responsive
screenshot-1739367787744

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@musale
Copy link
Contributor Author

musale commented Feb 13, 2025

For larger screens, the search resources button is not responsive screenshot-1739367787744

fixed.

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@musale musale merged commit daaacb1 into feat/fluent-v9-upgrade Feb 13, 2025
15 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-3473.centralus.azurestaticapps.net

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnickii Mnickii Mnickii approved these changes

@ElinorW ElinorW ElinorW left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@musale @ElinorW @Mnickii