Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signinactivity.md #9516

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

jpsantoscosta
Copy link
Contributor

Clarity: This revision explicitly explains that lastInteractiveSignInDateTime includes unsuccessful attempts, which may lead to misleading conclusions if one is trying to measure actual user engagement.

Guidance: It directs users to lastSuccessfulSignInDateTime when their goal is to identify when an account was effectively used.

Consistency: This change aligns the documentation with practical use cases, ensuring that developers and administrators select the appropriate property for their reporting needs.

Important

Required for API changes:

  • Link to API.md file: api-reference/v1.0/resources/signinactivity.md
  • Link to PR for public-facing schema changes (schema-Prod-beta/v1.0.csdl): (64f7252)

Add other supporting information, such as a description of the PR changes:

Please consider this change to help clarify the intended use of these properties. Thank you for your attention to this suggestion.


Important

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Only PRs that have met the minimum requirements for content review and have this label are reviewed.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Clarity: This revision explicitly explains that lastInteractiveSignInDateTime includes unsuccessful attempts, which may lead to misleading conclusions if one is trying to measure actual user engagement.

Guidance: It directs users to lastSuccessfulSignInDateTime when their goal is to identify when an account was effectively used.

Consistency: This change aligns the documentation with practical use cases, ensuring that developers and administrators select the appropriate property for their reporting needs.
Copy link

Learn Build status updates of commit 64f7252:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/resources/signinactivity.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Danielabom
Copy link
Contributor

@jpsantoscosta, hi. Please add the "ready for content review" label to indicate that the PR is ready for us to review. Thanks!

@jpsantoscosta
Copy link
Contributor Author

@Danielabom The option to add labels isn't available for me, so, not sure what to do here.

@jpsantoscosta jpsantoscosta marked this pull request as draft February 21, 2025 10:26
@jpsantoscosta jpsantoscosta marked this pull request as ready for review February 21, 2025 10:26
@jpsantoscosta jpsantoscosta marked this pull request as draft February 21, 2025 12:09
@jpsantoscosta jpsantoscosta marked this pull request as ready for review February 21, 2025 12:11
@Danielabom Danielabom self-assigned this Feb 21, 2025
@Danielabom Danielabom added the ready for content review PR is ready for a content review - content development and tech review are complete. label Feb 21, 2025
Copy link
Contributor

Thank you for indicating that your pull request is ready for content review, @jpsantoscosta. It has been added to the Content Review project and an available reviewer will be assigned in the next 15 business days, depending on demand.

Check the content review workflow here.

@Danielabom
Copy link
Contributor

@Danielabom The option to add labels isn't available for me, so, not sure what to do here.

@jpsantoscosta , I updated the label for you. Thanks! I'll review the PR today.

@Danielabom Danielabom merged commit 42cccaa into microsoftgraph:main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for content review PR is ready for a content review - content development and tech review are complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants