Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-EntraUserSponsor review suggestions #1369

Open
wants to merge 4 commits into
base: dbutoyi/user_sponsor
Choose a base branch
from

Conversation

SteveMutungi254
Copy link
Contributor

Added suggestions based on PR review.

@SteveMutungi254 SteveMutungi254 requested a review from a team as a code owner February 21, 2025 20:47
@SteveMutungi254 SteveMutungi254 added Ready For Review The PR Ready for Review P0 Highest priority labels Feb 21, 2025
Copy link

Learn Build status updates of commit 5f32af0:

✅ Validation status: passed

File Status Preview URL Details
module/Entra/Microsoft.Entra/Users/Get-EntraUserSponsor.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaUserSponsor.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit bdddaee:

✅ Validation status: passed

File Status Preview URL Details
module/docs/entra-powershell-beta/Users/Get-EntraBetaUserSponsor.md ✅Succeeded View (entra-powershell-beta-preview)
module/docs/entra-powershell-v1.0/Users/Get-EntraUserSponsor.md ✅Succeeded View (entra-powershell-preview)
module/Entra/Microsoft.Entra/Users/Get-EntraUserSponsor.ps1 ✅Succeeded
module/EntraBeta/Microsoft.Entra.Beta/Users/Get-EntraBetaUserSponsor.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@@ -56,16 +56,14 @@ In delegated scenarios with work or school accounts, the signed-in user needs a
```powershell
Connect-Entra -Scopes 'User.Read', 'User.Read.All' # User.Read.All is application-only permission (non-interactive login)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this comment. Connect-Entra -Scopes is an interactive login.
Also, it doesn't make sense to specify 'User.Read' and 'User.Read.All' at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority Ready For Review The PR Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants