Add Korean translation #452

gcyong · 2024-12-30T19:08:49Z

Someone did PR about Korean translation 6 years ago (#202 and #203).
But the translation is incomplete and there seems to not any update for the work long time.

Therefore, I'd like to suggest new Korean translation.

- copied from en-US resources

gcyong · 2024-12-30T19:12:47Z

@microsoft-github-policy-service agree

malxau-msft · 2025-01-11T08:05:29Z

Thanks for sending this, and sorry for being quiet. I have been looking into it.

malxau-msft

(Sorry, I'm still working through this. Up to FORMATDLG but posting what I've seen so far.)

malxau-msft · 2025-01-25T17:01:23Z

src/lang/winfile_ko-KR.dlg

+
+    CONTROL "찾기 대상:", -1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 5, 5, 60, 10
+    CONTROL "", IDD_NAME, "static", SS_SIMPLE | SS_NOPREFIX | WS_CHILD, 50, 5, 120, 10
+    CONTROL "Since:", -1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 5, 15, 60, 10


Is this missing?

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-25T17:16:08Z

src/lang/winfile_ko-KR.dlg

+    CONTROL "새 파일:", -1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 25, 12, 49, 10
+    CONTROL "", IDD_TO, "static", SS_LEFTNOWORDWRAP | SS_NOPREFIX | WS_CHILD, 75, 12, 165, 10
+    CONTROL "", IDD_DATE1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 75, 22, 170, 10
+    CONTROL "현재 파일:", -1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 25, 34, 49, 10


In the original translation, these two were swapped, and I think they should be - are you sure this is correct?

Yes, Korean spell checker recommends space two nouns, "현재" and "파일".

malxau-msft · 2025-01-25T17:41:40Z

src/lang/winfile_ko-KR.dlg

+BEGIN
+    CONTROL 32515, IDD_TEXT, "static", SS_ICON | WS_CHILD, 3, 12, 16, 16
+    CONTROL "", IDD_STATUS, "static", SS_LEFTNOWORDWRAP | SS_NOPREFIX | WS_CHILD, 25, 3, 203, 10
+    CONTROL "대상 파일:", -1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 25, 18, 44, 10


The original translation had "옮길 파일:" for this - would that be better?

Thank you! It's modified in 00d3118. 😊

Note : line 231 in this file is also modified as same reason.

malxau-msft · 2025-01-25T17:41:59Z

src/lang/winfile_ko-KR.dlg

+BEGIN
+    CONTROL 32515, IDD_TEXT, "static", SS_ICON | WS_CHILD, 3, 12, 16, 16
+    CONTROL "", IDD_STATUS, "static", SS_LEFTNOWORDWRAP | SS_NOPREFIX | WS_CHILD, 25, 3, 203, 10
+    CONTROL "대상 파일:", -1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 25, 18, 54, 10


The original translation had "이름 바꿀 파일:" for this - would that be better?

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-25T17:46:00Z

src/lang/winfile_ko-KR.dlg

+    DIALOGRESIZECONTROL { 0, 0, 100, 0 }
+    CONTROL "", IDD_NAME, "edit", ES_LEFT | WS_BORDER | WS_TABSTOP | WS_CHILD | ES_AUTOHSCROLL, 52, 5, 180, 12
+    DIALOGRESIZECONTROL { 0, 33, 0, 0 }
+    CONTROL "Sin&ce:", IDD_TEXT, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 5, 21, 45, 12


Is this missing?

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-25T17:52:15Z

src/lang/winfile_ko-KR.dlg

+    CONTROL         "현재 디렉터리: N", IDD_DIR, "Static", SS_SIMPLE | SS_NOPREFIX, 3, 6, 332, 10
+
+    DIALOGRESIZECONTROL { 0, 25, 0, 0 }
+    CONTROL         "대상(&T):", IDD_KK_TEXTTO, "Static", SS_LEFTNOWORDWRAP, 3, 33, 20, 10


The original translation used "옮길 위치" for this - would that be better?

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-25T17:53:02Z

src/lang/winfile_ko-KR.dlg

+    PUSHBUTTON      "도움말(&H)", IDD_HELP, 335, 40, 40, 14
+
+    DIALOGRESIZECONTROL { 0, 0, 0, 0 }
+    CONTROL         "원본(&F):", IDD_KK_TEXTFROM, "Static", SS_LEFTNOWORDWRAP, 3, 19, 20, 10


The original translation used "원래 위치" for this - would that be better?

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-25T17:57:21Z

src/lang/winfile_ko-KR.dlg

+FONT 8, "MS Shell Dlg"
+STYLE WS_BORDER | DS_MODALFRAME | WS_CAPTION | WS_DLGFRAME | WS_POPUP | WS_SYSMENU
+BEGIN
+    CONTROL "%d개 파일 선택", IDD_TEXT1, "static", SS_LEFTNOWORDWRAP | WS_CHILD, 5, 5, 144, 10


"~개" means pieces. The original translation is same.

malxau-msft

Ok, I'm done reviewing this, with a few questions. It looks generally fine though so I'm happy to merge it as-is. Let me know if you'd like to merge this or make further changes.

malxau-msft · 2025-01-27T05:30:46Z

src/lang/res_ko-KR.rc

+    MENUITEM    "심볼릭 링크(&Y)...\tF11", IDM_SYMLINK
+    MENUITEM    "하드 링크(&K)...\tShift+F11", IDM_HARDLINK
+    MENUITEM    "클립보드로 복사(&B)\tCtrl+C", IDM_COPYTOCLIPBOARD
+    MENUITEM    "글립보드로 잘라내기\tCtrl+X", IDM_CUTTOCLIPBOARD


Should this be 클?

Thank you! It's modified in 00d3118. 😊

Note : line 143 in this file is modified as same reason.

malxau-msft · 2025-01-27T05:37:42Z

src/lang/winfile_ko-KR.dlg

+BEGIN
+    CONTROL "", IDD_STATUS, "static", SS_SIMPLE | SS_NOPREFIX | WS_CHILD , 5, 5, 49, 10
+    CONTROL "", IDD_NAME, "static", WS_CHILD | SS_SIMPLE | SS_NOPREFIX, 55, 5, 192, 10
+    CONTROL "대상:", IDD_TOSTATUS, "static", SS_SIMPLE | SS_NOPREFIX | WS_CHILD, 5, 15, 25, 10


옮길 위치 ?

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-27T05:39:45Z

src/lang/res_ko-KR.rc

+    MENUITEM    "가로로 배열(&H)",   IDM_TILEHORIZONTALLY
+    MENUITEM    "세로로 배열(&T)\tShift+F4",      IDM_TILE
+    MENUITEM    "아이콘 정렬(&A)",       IDM_ARRANGE
+    MENUITEM    "새로고침(&R)\tF5",         IDM_REFRESH


최신 정보로 고침 ?

I think "새로고침" is not bad because it is familiar as "Refresh" and F5 hotkey in Korea.

malxau-msft · 2025-01-27T05:40:08Z

src/lang/res_ko-KR.rc

+    IDS_PRINTONLYONE        "여러 파일을 인쇄할 수 없습니다.\n\n파일을 하나만 선택한 다음 다시 하십시오."                                               /* 128 */
+
+    IDS_CURDIRIS,           "현재 디렉터리: %s"                                                                                                    /* 128 */
+    IDS_CURDIRSARE,         "Other: "


Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-27T05:42:20Z

src/lang/res_ko-KR.rc

+    IDS_KK_COPYFROMSTR,     "원본(&F):"
+    IDS_KK_COPYTOSTR,       "대상(&T):"
+    IDS_KK_RENAMEFROMSTR,   "원본(&F):"
+    IDS_KK_RENAMETOSTR,     "대상(&T):"


Does it make sense for these to be more specific? NT had:

"원래 위치(&F):"
"복사할 위치(&T):"
"이전 이름(&O):"
"새 이름(&N):"

Thank you! It's modified in 00d3118. 😊

malxau-msft · 2025-01-27T05:44:09Z

src/lang/res_ko-KR.rc

+    IDS_REMOVINGDIRMSG,     "제거하는 중:"                     /* 32 */
+    IDS_REMOVINGMSG,        "제거하는 중..."                   /* 32 */
+    IDS_COPYINGMSG,         "복사하는 중:"                      /* 32 */
+    IDS_OPENINGMSG,         "복사하는 중..."                    /* 32 */


Copy/paste error? NT had "열기"

Thank you! It's modified in 00d3118. 😊

gcyong · 2025-01-27T06:24:36Z

@malxau-msft Thank you for your review! I'd like to modify some changes. I will comment after working.

gcyong · 2025-01-27T08:00:27Z

@malxau-msft I modified resources as your almost comments because of reasonable. Thank you for your review. 👍

* Add Resources for Korean - copied from en-US resources * Translate menu to Korean * Modify incorrect macro * Modify menu text * Translate menu and suggestion to Korean * Translate dialog to Korean * Fix typo; modify "Goto Directory" menu caption * Fix typo * Translate OK button in About * Fix typo; missing and incorrect translation (cherry picked from commit 6b5541d)

gcyong added 8 commits December 29, 2024 04:20

Add Resources for Korean

307eaec

- copied from en-US resources

Translate menu to Korean

74d8443

Modify incorrect macro

9aae2f9

Modify menu text

fd8eff1

Translate menu and suggestion to Korean

ff2e2f5

Translate dialog to Korean

98477d5

Fix typo; modify "Goto Directory" menu caption

c5cf0c7

Fix typo

a9c3a98

Translate OK button in About

c6ef065

malxau-msft mentioned this pull request Jan 11, 2025

Add resize dialog info to pt-PT #453

Merged

malxau-msft reviewed Jan 25, 2025

View reviewed changes

malxau-msft approved these changes Jan 27, 2025

View reviewed changes

gcyong changed the title ~~Add Korean translation~~ WIP Add Korean translation Jan 27, 2025

Fix typo; missing and incorrect translation

00d3118

gcyong changed the title ~~WIP Add Korean translation~~ Add Korean translation Jan 27, 2025

malxau-msft merged commit 6b5541d into microsoft:master Jan 28, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Korean translation #452

Add Korean translation #452

gcyong commented Dec 30, 2024 •

edited

Loading

gcyong commented Dec 30, 2024

malxau-msft commented Jan 11, 2025

malxau-msft left a comment

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025 •

edited

Loading

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft Jan 25, 2025

gcyong Jan 27, 2025

malxau-msft left a comment

malxau-msft Jan 27, 2025

gcyong Jan 27, 2025

malxau-msft Jan 27, 2025

gcyong Jan 27, 2025

malxau-msft Jan 27, 2025

gcyong Jan 27, 2025

malxau-msft Jan 27, 2025

gcyong Jan 27, 2025

malxau-msft Jan 27, 2025

gcyong Jan 27, 2025

malxau-msft Jan 27, 2025

gcyong Jan 27, 2025

gcyong commented Jan 27, 2025

gcyong commented Jan 27, 2025

Add Korean translation #452

Add Korean translation #452

Conversation

gcyong commented Dec 30, 2024 • edited Loading

gcyong commented Dec 30, 2024

malxau-msft commented Jan 11, 2025

malxau-msft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gcyong Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

malxau-msft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gcyong commented Jan 27, 2025

gcyong commented Jan 27, 2025

gcyong commented Dec 30, 2024 •

edited

Loading

gcyong Jan 27, 2025 •

edited

Loading