mcp: work on --add-mcp CLI #243282
Merged
mcp: work on --add-mcp CLI #243282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
commented
Mar 11, 2025
Comment on lines
+35
to
+47
| // This is not right because settings are nested in .code-workspace... | ||
| const workspaceConfigService = new ConfigurationService(URI.file(workspace), this._fileService, this._policyService, this._logService); | ||
| await this.updateMcpInConfig(workspaceConfigService, configs); | ||
| workspaceConfigService.dispose(); | ||
| } else { | ||
| // todo: this seems incorrect. IConfigurationService.getValue() fails if | ||
| // if we point it to mcp.json and call `sevice.getValue()` with no args | ||
| // but if we point to launch.json, it writes it there instead of the | ||
| // standalone config file. This technically works but is undesirable. | ||
| const workspaceFile = URI.joinPath(URI.file(workspace), '.vscode', 'settings.json'); | ||
| const workspaceFolderConfigService = new ConfigurationService(workspaceFile, this._fileService, this._policyService, this._logService); | ||
| await this.updateMcpInConfig(workspaceFolderConfigService, configs); | ||
| workspaceFolderConfigService.dispose(); |
There was a problem hiding this comment.
@sandy081 I could use some help figuring out how to do this. I would like people (or more accurately, tools that install MCP servers) to be able to do code --add-mcp ... --add-mcp-to-workspace <folder or .code-workspace>. This runs in the CLI process and works for installing in the user data dir but making our own config services here is probably not the right thing to do and it doesn't work 😛
connor4312
force-pushed
the
connor4312/mcp-cli-install
branch
from
7ed5bbf to
527df30
Compare
connor4312
commented
Mar 11, 2025
| @@ -410,9 +413,12 @@ function indent(count: number): string { | |||
| function wrapText(text: string, columns: number): string[] { | |||
| const lines: string[] = []; | |||
| while (text.length) { | |||
| const index = text.length < columns ? text.length : text.lastIndexOf(' ', columns); | |||
There was a problem hiding this comment.
there was a 10-year-old bug here where this would crash if the last space in the line was the first character!
bhavyaus
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #243224