Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure documents created via chat edits are active #243130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Mar 10, 2025

@DonJayamanne DonJayamanne self-assigned this Mar 10, 2025
@DonJayamanne DonJayamanne requested a review from joyceerhl March 11, 2025 00:20
@DonJayamanne DonJayamanne marked this pull request as ready for review March 11, 2025 00:20
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 11, 2025
Copy link
Collaborator

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do this, if the model is creating multiple files then we would reveal each of them in turn. I think ideally there would be a way for us to reveal the editor if the active editor in the target group is not a 'real' editor (i.e. welcome editor, settings editor). This might be a feature request for @bpasero

@bpasero
Copy link
Member

bpasero commented Mar 11, 2025

I guess that depends on what you call a "real" editor, there is custom editors that are non-textual too.

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Mar 11, 2025

the active editor in the target group is not a 'real' editor (i.e. welcome editor, settings editor)

sure but i think it’s safe to say that it’s impossible to create such filles and edit those uris via chat edits? After all that’s the context if this line (line above creates this file). I’d the context here is for creating files and then opening them,
also at this stage i am not sure what needs to be done here

Got it now, misunderstood the earlier comment.

@joyceerhl
Copy link
Collaborator

Good point. Maybe we want to reveal editors if the current editor is not 'editable', i.e. it's not a text editor or notebook editor

@bpasero
Copy link
Member

bpasero commented Mar 11, 2025

But custom editors are editable, and they are not text or notebooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants