macOS: window controls stop working when zoomed in (fix #242890) #243120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Thanks!
I was wrong, the height value does seem respected on macOS https://github.com/electron/electron/blob/eb126eecb0e259fafafe8097c1cb8dac017dd07e/shell/browser/native_window.cc#L109-L123, only the color and symbolColor are ignored.
Setting the boolean seems like the right thing to do on macOS if we want to default to system defined height.
|
I think this should also address #242870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deepak1556 looks like buggy stuff is happening if on macOS we define a
height: 29intitleBarOverlayand later callsetWindowButtonPosition.I had thought that all properties on macOS are ignored, but that does not seem to be the case, so the safest seems to be to go with the
titleBarOverlay: trueoption?