Allow suggestions to pass through if outside accept flow #243103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the accept flow check to consider suggestion items if outside the accept flow. Putting the check for the accept flow inside this block seems to prevent suggestions from being triggered if there is an inline edit but the user is outside the accept flow, but showing an inline completion is still possible.
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the accept flow check to consider suggestion items if outside the accept flow.
Putting the check for the accept flow inside this block seems to prevent suggestions from being triggered if there is an inline edit but the user is outside the accept flow, but showing an inline completion is still possible.