-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task status API #243092
base: main
Are you sure you want to change the base?
add task status API #243092
Conversation
export enum TaskEventKind { | ||
DependsOnStarted = 'dependsOnStarted', | ||
AcquiredInput = 'acquiredInput', | ||
Start = 'start', | ||
ProcessStarted = 'processStarted', | ||
Active = 'active', | ||
Inactive = 'inactive', | ||
Changed = 'changed', | ||
Terminated = 'terminated', | ||
ProcessEnded = 'processEnded', | ||
End = 'end' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look a little mysterious to me, is this too detailed for extensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we'd limit the scope for extensions when we track and find these useful internally already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd want more details docs on these and/or simpler versions for extension. Tasks do a lot of things I don't think extension authors always know about. I don't even know what half these are without reading vscode sources 😛
also -- what is the status I should look for in copilot that's emitted when a problem matcher begins/ends/has an error state? Or is that not reflected here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe active and inactive do what you want, will confirm and add documentation for each type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Active and inactive did not do what we wanted. I have added the following:
vscode/src/vscode-dts/vscode.proposed.taskStatus.d.ts
Lines 40 to 47 in 9125333
/** Indicates that a task's problem matcher has started */ | |
ProblemMatcherStarted = 'problemMatcherStarted', | |
/** Indicates that a task's problem matcher has ended */ | |
ProblemMatcherEnded = 'problemMatcherEnded', | |
/** Indicates that a task's problem matcher has found errors */ | |
ProblemMatcherFoundErrors = 'problemMatcherFoundErrors' |
fixes #241772