Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task status API #243092

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

add task status API #243092

wants to merge 13 commits into from

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 10, 2025

fixes #241772

@meganrogge meganrogge requested a review from connor4312 March 10, 2025 16:38
@meganrogge meganrogge self-assigned this Mar 10, 2025
@meganrogge meganrogge added this to the March 2025 milestone Mar 10, 2025
@meganrogge meganrogge requested a review from Tyriar March 10, 2025 19:44
Comment on lines 9 to 20
export enum TaskEventKind {
DependsOnStarted = 'dependsOnStarted',
AcquiredInput = 'acquiredInput',
Start = 'start',
ProcessStarted = 'processStarted',
Active = 'active',
Inactive = 'inactive',
Changed = 'changed',
Terminated = 'terminated',
ProcessEnded = 'processEnded',
End = 'end'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look a little mysterious to me, is this too detailed for extensions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we'd limit the scope for extensions when we track and find these useful internally already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd want more details docs on these and/or simpler versions for extension. Tasks do a lot of things I don't think extension authors always know about. I don't even know what half these are without reading vscode sources 😛

also -- what is the status I should look for in copilot that's emitted when a problem matcher begins/ends/has an error state? Or is that not reflected here?

Copy link
Contributor Author

@meganrogge meganrogge Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe active and inactive do what you want, will confirm and add documentation for each type.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active and inactive did not do what we wanted. I have added the following:

/** Indicates that a task's problem matcher has started */
ProblemMatcherStarted = 'problemMatcherStarted',
/** Indicates that a task's problem matcher has ended */
ProblemMatcherEnded = 'problemMatcherEnded',
/** Indicates that a task's problem matcher has found errors */
ProblemMatcherFoundErrors = 'problemMatcherFoundErrors'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose task status through VS Code API
3 participants