Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CHANGE_CELL_LANGUAGE on "Select language" in the empty notebook cell hint. #242835

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alievilshat
Copy link

In the notebook empty cell editor override the default language selection command with CHANGE_CELL_LANGUAGE command.

Steps to test:

  • Create a notebook file.
  • Create a code cell.
  • Click on "Select a language" in the cell hint "Select language, or fill with template ...".
    (Note: if the hint is not visible, please patch the fix: Fixed wrong negation in the _shouldRenderHint logic. #242479)
  • Choose a language.
  • Verify that the cell language is updated.

Fixes: #242826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language picker from the "Select language" hint in an empty notebook cell doesn't do anything.
4 participants