Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide no suggestions indicator when a user types more input #242699

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Mar 5, 2025

fixes #239791

A user typing more input will just reduce the likelihood of a valid completion , so makes sense to hide it until explicitly invoked again.

@meganrogge meganrogge requested a review from Tyriar March 5, 2025 15:40
@meganrogge meganrogge self-assigned this Mar 5, 2025
@meganrogge meganrogge added this to the March 2025 milestone Mar 5, 2025
@meganrogge meganrogge enabled auto-merge (squash) March 5, 2025 15:40
@meganrogge meganrogge changed the title don't keep no suggestions around as a user keeps typing hide no suggestions indicator as a user keeps typing Mar 5, 2025
@meganrogge meganrogge changed the title hide no suggestions indicator as a user keeps typing hide no suggestions indicator when a user types more input Mar 5, 2025
@meganrogge meganrogge merged commit 5e317a1 into main Mar 11, 2025
8 checks passed
@meganrogge meganrogge deleted the merogge/empty branch March 11, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No suggestions sticks around when typing
2 participants