Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM - Add settings to toggle diff decorator pattern #146724

Merged
merged 3 commits into from
Apr 5, 2022
Merged

SCM - Add settings to toggle diff decorator pattern #146724

merged 3 commits into from
Apr 5, 2022

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Apr 4, 2022

No description provided.

@lszomoru lszomoru added the scm General SCM compound issues label Apr 4, 2022
@lszomoru lszomoru added this to the April 2022 milestone Apr 4, 2022
@lszomoru lszomoru requested a review from joaomoreno April 4, 2022 13:17
@lszomoru lszomoru self-assigned this Apr 4, 2022
joaomoreno
joaomoreno requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create the 5 decorations upfront, instead of creating new ones dynamically when the setting change.

@lszomoru lszomoru marked this pull request as ready for review April 5, 2022 13:24
@lszomoru lszomoru merged commit b0990b9 into main Apr 5, 2022
@lszomoru lszomoru deleted the lszomoru/diff-decorator-setting branch April 5, 2022 18:53
@gjsjohnmurray gjsjohnmurray mentioned this pull request Apr 6, 2022
Open
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2022
@hediet
Copy link
Member

hediet commented Dec 8, 2023

For reference: #142809

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

Assignees

@lszomoru lszomoru

Labels
scm General SCM compound issues
Projects
None yet
Milestone
April 2022
Development

Successfully merging this pull request may close these issues.
3 participants
@lszomoru @hediet @joaomoreno