Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure survey notification respects telemetry.disableFeedback setting #24903

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

luabud
Copy link
Member

@luabud luabud commented Mar 14, 2025

Fixes #24904

Follow up to microsoft/vscode#243276

This is to ensure that we only show the survey feedback if VS Code's telemetry.disableFeedback setting isn't enabled

@luabud luabud marked this pull request as ready for review March 14, 2025 16:42
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 14, 2025
@luabud luabud merged commit 6b7d8d1 into main Mar 14, 2025
88 of 91 checks passed
@luabud luabud deleted the luabud/enablesurveysetting branch March 14, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect VS Code core telemetry.disableFeedback setting
2 participants